Stream: git-wasmtime

Topic: wasmtime / PR #4211 Fix failing cranelift-object tests in...

Wasmtime GitHub notifications bot (Jun 02 2022 at 19:34):

cfallin edited PR #4211 from fix-cranelift-object-test to main:

Rust 1.61 changed the way Debug output looks for strings with null
bytes in them. Tests currently pass in Rust 1.61 but not with prior versions.
Generally we only support latest stable Rust but here it seems worthwhile
to fix a brittle specific-error-string match. This makes the expectations more
generic while still capturing the important part ("has a null byte").

Fixes #4210.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 02 2022 at 20:34):

cfallin merged PR #4211.

Last updated: Nov 22 2024 at 17:03 UTC