abrown opened PR #4207 from bench-wasi-flags
to main
:
When benchmarking in Sightglass, @brianjjones has found it necessary to
enable the wasi-nn module. The current way to do so is to alter the
engine build script to pass--features wasi-nn
so that this crate can
run code relying on these imports. This change allows the user to
instead pass the WASI modules using the engine flags added in #4096.
This could look something like the following in Sightglass:sightglass-cli benchmark ... --engine-flags '--wasi-modules experimental-wasi-nn'
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
abrown requested fitzgen for a review on PR #4207.
fitzgen submitted PR review.
abrown updated PR #4207 from bench-wasi-flags
to main
.
jameysharp submitted PR review.
abrown updated PR #4207 from bench-wasi-flags
to main
.
abrown merged PR #4207.
Last updated: Dec 23 2024 at 12:05 UTC