Stream: git-wasmtime

Topic: wasmtime / PR #4207 bench-api: configure WASI modules bas...

Wasmtime GitHub notifications bot (Jun 02 2022 at 00:48):

abrown opened PR #4207 from bench-wasi-flags to main:

When benchmarking in Sightglass, @brianjjones has found it necessary to
enable the wasi-nn module. The current way to do so is to alter the
engine build script to pass --features wasi-nn so that this crate can
run code relying on these imports. This change allows the user to
instead pass the WASI modules using the engine flags added in #4096.
This could look something like the following in Sightglass:

sightglass-cli benchmark ... --engine-flags '--wasi-modules experimental-wasi-nn'

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 02 2022 at 00:48):

abrown requested fitzgen for a review on PR #4207.

Wasmtime GitHub notifications bot (Jun 02 2022 at 21:13):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2022 at 22:10):

abrown updated PR #4207 from bench-wasi-flags to main.

Wasmtime GitHub notifications bot (Sep 23 2022 at 16:41):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Sep 23 2022 at 17:47):

abrown updated PR #4207 from bench-wasi-flags to main.

Wasmtime GitHub notifications bot (Sep 23 2022 at 18:36):

abrown merged PR #4207.

Last updated: Nov 22 2024 at 17:03 UTC