Stream: git-wasmtime

Topic: wasmtime / PR #4206 Add trampoline compilation support fo...

Wasmtime GitHub notifications bot (Jun 01 2022 at 21:58):

alexcrichton opened PR #4206 from component-trampolines to main:

This commit adds support to the component model implementation for
compiling trampolines suitable for calling host imports. Currently this
is purely just the compilation side of things, modifying the
wasmtime-cranelift crate and additionally filling out a new
VMComponentOffsets type (similar to VMOffsets). The actual creation
of a VMComponentContext is still not performed and will be a
subsequent PR.

Internally though some tests are actually possible with this where we at
least assert that compilation of a component and creation of everything
in-memory doesn't panic or trip any assertions, so some tests are added
here for that as well.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 01 2022 at 21:58):

alexcrichton requested fitzgen for a review on PR #4206.

Wasmtime GitHub notifications bot (Jun 02 2022 at 12:51):

alexcrichton updated PR #4206 from component-trampolines to main.

Wasmtime GitHub notifications bot (Jun 02 2022 at 21:12):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2022 at 21:12):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2022 at 21:12):

fitzgen created PR review comment:

Aside: should this be VMStringEncoding since we pass it to JIT code?

Wasmtime GitHub notifications bot (Jun 02 2022 at 21:12):

fitzgen created PR review comment:

I guess the same goes for ValRaw, although this is relatively long-standing at this point.

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:00):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:00):

alexcrichton created PR review comment:

Hm perhaps yeah, although this is defined in wasmtime-environ which doesn't have VM* things in general. I did leave documentation there explaining the repr(u8) as well, so I think I'll leave this as-is to avoid too many definitions of the same thing, but we can always tweak in the future of course.

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:01):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:01):

alexcrichton created PR review comment:

True yeah, although I sort of just invented the ValRaw name as it was the raw version of wasmtime::Val. We don't otherwise export VM* types to the outside world which wasmtime::ValRaw is, though. One way to solve this perhaps would be a struct ValRaw(VMValRaw) or similar, but I'm not sure if it's worth it per se.

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:01):

alexcrichton merged PR #4206.

Last updated: Nov 22 2024 at 16:03 UTC