Stream: git-wasmtime

Topic: wasmtime / PR #4204 Add a first-class `StoreId` type to W...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 18:46):

alexcrichton opened PR #4204 from store-id to main:

This commit adds a StoreId type to uniquely identify a store
internally within Wasmtime. This hasn't been created previously as it
was never really needed but I've run across a case for its usage in the
component model so I've gone ahead and split out a commit to add this type.

While I was here in this file I opted to improve some other
miscellaneous things as well:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 18:47):

alexcrichton requested fitzgen for a review on PR #4204.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 18:57):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 18:57):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 18:57):

cfallin created PR review comment:

s/stores/store/

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 18:57):

cfallin created PR review comment:

I think this can be a Relaxed fetch_add, because the sequence in which IDs are allocated doesn't matter (every ID is as good as any other and is opaque), so there's no need to synchronize this allocation step with respect to any other loads/stores. I wrote a similar justification over here for CompiledModuleId, I guess we could just point to that as justification.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 18:57):

cfallin created PR review comment:

"... inserted into a store" --> add "and stores are never shrunk, so an index once valid is always valid", just for extra clarity?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 19:02):

alexcrichton updated PR #4204 from store-id to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 19:13):

alexcrichton updated PR #4204 from store-id to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2022 at 19:46):

alexcrichton merged PR #4204.


Last updated: Dec 23 2024 at 12:05 UTC