sparker-arm opened PR #4201 from aarch64-isle-iaddpairwise
to main
:
Copyright (c) 2022, Arm Limited.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
sparker-arm requested cfallin for a review on PR #4201.
cfallin submitted PR review.
cfallin submitted PR review.
cfallin created PR review comment:
s/Extractor/Constructor/
cfallin created PR review comment:
Can we add some tests for the same-arg case as well? (Or I may have missed some that exist elsewhere?)
sparker-arm submitted PR review.
sparker-arm created PR review comment:
Yeah, they already exist at the top of this file.
sparker-arm updated PR #4201 from aarch64-isle-iaddpairwise
to main
.
sparker-arm merged PR #4201.
Last updated: Dec 23 2024 at 13:07 UTC