Wasmtime GitHub notifications bot (May 31 2022 at 21:42): Wasmtime GitHub notifications bot (May 31 2022 at 21:42):cfallin opened PR #4199 from regalloc-0.2.1 to main:
This resolves an edge-case where mul.i128 with an input that continues
to be live after the instruction could cause an invalid regalloc
constraint (basically, the regalloc did not previously support an
instruction use and def both being constrained to the same physical reg;
and the "mul" variant used for mul.i128 on x64 was the only instance of
such operands in Cranelift).Causes two extra move instructions in the mul.i128 filetest, but that's
the price to pay for the slightly more general (works in all cases)
handling of the constraints.See bytecodealliance/regalloc2#53 for the original bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 31 2022 at 21:42):cfallin requested fitzgen for a review on PR #4199.
Wasmtime GitHub notifications bot (May 31 2022 at 21:42):cfallin requested abrown for a review on PR #4199.
Wasmtime GitHub notifications bot (Jun 01 2022 at 20:26):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 01 2022 at 20:26):cfallin merged PR #4199.
Last updated: Dec 23 2024 at 12:05 UTC