Stream: git-wasmtime

Topic: wasmtime / PR #4193 Capture unresolved backtraces on traps

Wasmtime GitHub notifications bot (May 27 2022 at 20:29):

alexcrichton opened PR #4193 from faster-tests to main:

I was running tests recently and was surprised that the --test all
test was taking more than a minute to run when I didn't recall it ever
taking more than a minute historically. A bisection pointed out #4183 as
the cause and after re-reviewing I realized I forgot that we capture
unresolved backtraces by default (and don't actually resolve them
anywhere yet but that's a problem for another day) rather than resolved
backtraces. This means that it's intended that we use
Backtrace::new_unresolved instead of Backtrace::new in the
traphandlers crate.

The reason that tests were running so slowly is that the tests which
deal with deep stacks (e.g. stack overflow) would take forever in
testing as the Rust-based decoding of DWARF information is egregiously
slow in unoptimized mode. I did discover independently that optimizing
these dependencies makes the tests ~6x faster, but that's irrelevant if
we're not symbolicating in the first place.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 27 2022 at 20:30):

alexcrichton requested pchickey for a review on PR #4193.

Wasmtime GitHub notifications bot (May 31 2022 at 14:51):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (May 31 2022 at 14:56):

alexcrichton merged PR #4193.

Last updated: Nov 22 2024 at 16:03 UTC