Stream: git-wasmtime

Topic: wasmtime / PR #4176 Cranelift: fix use of pinned reg with...

Wasmtime GitHub notifications bot (May 20 2022 at 19:01):

cfallin requested abrown for a review on PR #4176.

Wasmtime GitHub notifications bot (May 20 2022 at 19:01):

cfallin opened PR #4176 from pinned-regs-sysv to main:

Previously, the pinned register (enabled by the enable_pinned_reg
Cranelift setting and used via the get_pinned_reg and set_pinned_reg
CLIF ops) was only used when Cranelift was embedded in SpiderMonkey, in
order to support a pinned heap register. SpiderMonkey has its own
calling convention in Cranelift (named after the integration layer,
"Baldrdash").

However, the feature is more general, and should be usable with the
default system calling convention too, e.g. SysV or Windows Fastcall.

This PR fixes the ABI code to properly treat the pinned register as a
globally allocated register -- and hence an implicit input and output to
every function, not saved/restored in the prologue/epilogue -- for SysV
on x86-64 and aarch64, and Fastcall on x86-64.

Fixes #4170.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 20 2022 at 19:01):

cfallin requested akirilov-arm for a review on PR #4176.

Wasmtime GitHub notifications bot (May 20 2022 at 19:01):

cfallin has marked PR #4176 as ready for review.

Wasmtime GitHub notifications bot (May 23 2022 at 11:57):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (May 23 2022 at 16:18):

cfallin merged PR #4176.

Last updated: Nov 22 2024 at 16:03 UTC