Stream: git-wasmtime

Topic: wasmtime / PR #4171 Refactor binary-compatible-builds for...

Wasmtime GitHub notifications bot (May 20 2022 at 14:10):

alexcrichton opened PR #4171 from more-compatible-builds to main:

I was poking around this yesterday and noticed a few things that could
be improved for our release builds:

• The centos container for the x86_64 builds contained a bunch of extra
  tooling we no longer need such as python3 and a C++ compiler. Along
  with custom toolchain things this could all get removed since the C we
  include now is quite simple.

• The aarch64 and s390x cross-compiled builds had relatively high glibc
  version requirements compared to the x86_64 build. This was because we
  don't use a container to build the cross-compiled binaries. I added
  containers here along the lines of the x86_64 build to use an older
  glibc to build the release binary to lower our version requirement.
  This lower the aarch64 version requirement from glibc 2.28 to 2.17.
  Additionally the s390x requirement dropped from 2.28 to 2.16.

• To make the containers a bit easier to read/write I added
  Dockerfiles for them in a new ci/docker directory instead of
  hardcoding install commands in JS.

This isn't intended to be a really big change or anything for anyone,
but it's intended to keep our Linux-based builds consistent at least as
best we can.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 20 2022 at 14:10):

alexcrichton updated PR #4171 from more-compatible-builds to main.

Wasmtime GitHub notifications bot (May 20 2022 at 17:08):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (May 20 2022 at 17:13):

alexcrichton merged PR #4171.

Last updated: Nov 22 2024 at 17:03 UTC