Wasmtime GitHub notifications bot (May 17 2022 at 05:52): Wasmtime GitHub notifications bot (May 17 2022 at 05:52):cfallin opened PR #4157 from use-regalloc2-0.1.3 to main:
This pulls in bytecodealliance/regalloc2#49, which slightly improves
codegen in soem cases where a safepoint (for reference-typed values)
occurs in the same liverange as a register-constraineed use. For
example, in bytecodealliance/wasmtime#3785, an extra move instruction
appeared and a callee-save register was used (necessitating a more
expensive prologue) because of suboptimal splitting heuristics, which
this PR fixes. The updated RA2 heuristics appear to have no measured
downsides in existing benchmarks and improve the manually-observed
codegen issue.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 17 2022 at 05:53):cfallin updated PR #4157 from use-regalloc2-0.1.3 to main.
Wasmtime GitHub notifications bot (May 17 2022 at 05:53):cfallin edited PR #4157 from use-regalloc2-0.1.3 to main:
This pulls in bytecodealliance/regalloc2#49, which slightly improves
codegen in some cases where a safepoint (for reference-typed values)
occurs in the same liverange as a register-constraineed use. For
example, in bytecodealliance/wasmtime#3785, an extra move instruction
appeared and a callee-save register was used (necessitating a more
expensive prologue) because of suboptimal splitting heuristics, which
this PR fixes. The updated RA2 heuristics appear to have no measured
downsides in existing benchmarks and improve the manually-observed
codegen issue.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 17 2022 at 05:54):cfallin edited PR #4157 from use-regalloc2-0.1.3 to main:
This pulls in bytecodealliance/regalloc2#49, which slightly improves
codegen in some cases where a safepoint (for reference-typed values)
occurs in the same liverange as a register-constrained use. For
example, in bytecodealliance/wasmtime#3785, an extra move instruction
appeared and a callee-save register was used (necessitating a more
expensive prologue) because of suboptimal splitting heuristics, which
this PR fixes. The updated RA2 heuristics appear to have no measured
downsides in existing benchmarks and improve the manually-observed
codegen issue.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 17 2022 at 05:54):cfallin updated PR #4157 from use-regalloc2-0.1.3 to main.
Wasmtime GitHub notifications bot (May 17 2022 at 17:36):cfallin updated PR #4157 from use-regalloc2-0.1.3 to main.
Wasmtime GitHub notifications bot (May 17 2022 at 17:36):cfallin requested fitzgen for a review on PR #4157.
Wasmtime GitHub notifications bot (May 17 2022 at 17:36):cfallin requested abrown for a review on PR #4157.
Wasmtime GitHub notifications bot (May 18 2022 at 18:37):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 18 2022 at 18:48):cfallin merged PR #4157.
Last updated: Dec 23 2024 at 12:05 UTC