Wasmtime GitHub notifications bot (May 12 2022 at 19:11): Wasmtime GitHub notifications bot (May 12 2022 at 19:11):cfallin opened PR #4151 from isle-errors-lines to main:
In #4143 we made ISLE compilation part of the normal build flow again,
to avoid the issues with the checked-in source. To make this acceptably
fast, we cut down dependencies of the ISLE compiler, so the "fancy"
error printing is now optional. When not included, it just prints error
messages to stderr in a list. However, this did not include file
locations. It might be nice to have this without enabling the "fancy
printing" and waiting for that to build.Fortunately most of the plumbing for this was already present (we had it
at one point before switching to miette). This PR adds back locations to
the basic error output. It now looks like:Error building ISLE files: ISLE errors: src/isa/aarch64/inst.isle:1:1: parse error: Unexpected token Symbol("asdf")<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 12 2022 at 19:11):cfallin requested fitzgen for a review on PR #4151.
Wasmtime GitHub notifications bot (May 12 2022 at 19:13):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 12 2022 at 19:55):cfallin merged PR #4151.
Last updated: Nov 22 2024 at 16:03 UTC