Wasmtime GitHub notifications bot (May 11 2022 at 17:33): Wasmtime GitHub notifications bot (May 11 2022 at 17:33):cfallin opened PR #4141 from no-vector-div to main:
In #4104 we discussed whether it makes sense for the division and
remainder ops to support vector types. We concluded that because most
hardware doesn't support it directly, it probably is not ideal to force
all backends to polyfill it. In the future we can always reverse this
decision, perhaps with a platform-independent legalization.This PR restricts the allowed types on the CLIF ops to integer types
only.Fixes #4104.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 11 2022 at 17:33):cfallin requested abrown for a review on PR #4141.
Wasmtime GitHub notifications bot (May 11 2022 at 17:33):cfallin requested akirilov-arm for a review on PR #4141.
Wasmtime GitHub notifications bot (May 11 2022 at 17:35):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 11 2022 at 18:10):cfallin merged PR #4141.
Last updated: Nov 22 2024 at 16:03 UTC