Stream: git-wasmtime

Topic: wasmtime / PR #4141 Cranelift: division/remainder CLIF op...


view this post on Zulip Wasmtime GitHub notifications bot (May 11 2022 at 17:33):

cfallin opened PR #4141 from no-vector-div to main:

In #4104 we discussed whether it makes sense for the division and
remainder ops to support vector types. We concluded that because most
hardware doesn't support it directly, it probably is not ideal to force
all backends to polyfill it. In the future we can always reverse this
decision, perhaps with a platform-independent legalization.

This PR restricts the allowed types on the CLIF ops to integer types
only.

Fixes #4104.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (May 11 2022 at 17:33):

cfallin requested abrown for a review on PR #4141.

view this post on Zulip Wasmtime GitHub notifications bot (May 11 2022 at 17:33):

cfallin requested akirilov-arm for a review on PR #4141.

view this post on Zulip Wasmtime GitHub notifications bot (May 11 2022 at 17:35):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 11 2022 at 18:10):

cfallin merged PR #4141.


Last updated: Dec 23 2024 at 12:05 UTC