Wasmtime GitHub notifications bot (May 11 2022 at 12:35): Wasmtime GitHub notifications bot (May 11 2022 at 12:35):sparker-arm opened PR #4140 from isle-atomic-cas to main:
Copyright (c) 2022, Arm Limited.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 11 2022 at 18:11):cfallin submitted PR review.
Wasmtime GitHub notifications bot (May 11 2022 at 18:11):cfallin submitted PR review.
Wasmtime GitHub notifications bot (May 11 2022 at 18:11):cfallin created PR review comment:
can we either give this rule a higher priority (
(rule 1 (lower ...))), or else add the complementary predicate(not_use_lse)to the rule below? Until we have explicit fallback semantics in ISLE (#3751) I'd prefer to be a little more explicit about ISA predicates I think (even if we haven't been perfect about this everywhere).
Wasmtime GitHub notifications bot (May 12 2022 at 07:53):sparker-arm updated PR #4140 from isle-atomic-cas to main.
Wasmtime GitHub notifications bot (May 12 2022 at 08:37):sparker-arm updated PR #4140 from isle-atomic-cas to main.
Wasmtime GitHub notifications bot (May 25 2022 at 08:19):sparker-arm merged PR #4140.
Last updated: Nov 22 2024 at 17:03 UTC