Wasmtime GitHub notifications bot (May 10 2022 at 17:23): Wasmtime GitHub notifications bot (May 10 2022 at 17:23):cfallin opened PR #4120 from fix-x64-select-filetest to main:
This test was added between the last CI run on #4088 and its merge to
main, and the changes in #4088 (use of constants directly in instruction
via load from constant pool, rather than from a register initialized by
a separate instruction) cause it to fail now.This PR alters the test to be invariant to regalloc and argument
decisions during lowering, as the test is really checking (per the
comment) that we get two cmoves without an intervening move. As such, it
just matches the instruction opcodes, irrespective of the arguments.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 10 2022 at 17:23):cfallin requested alexcrichton for a review on PR #4120.
Wasmtime GitHub notifications bot (May 10 2022 at 17:26):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 10 2022 at 17:56):cfallin merged PR #4120.
Last updated: Oct 23 2024 at 20:03 UTC