Stream: git-wasmtime

Topic: wasmtime / PR #4116 Narrow `allow(dead_code)` declarations

view this post on Zulip Wasmtime GitHub notifications bot (May 09 2022 at 18:23):

bnjbvr opened PR #4116 from narrow-dead-code to main:

Having module wide allow(dead_code) may hide some code that's really
dead. In this commit I just narrowed the declarations to the specific
enum variants that were not used (as it seems reasonable to keep them
and their handling in all the matches, for future use). And the compiler
found more dead code that I think we can remove safely in the short
term.

With this, the only files annotated with a module-wide
allow(dead_code) are isle-generated files.

view this post on Zulip Wasmtime GitHub notifications bot (May 09 2022 at 18:31):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 10 2022 at 09:30):

bnjbvr updated PR #4116 from narrow-dead-code to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 10 2022 at 10:02):

bnjbvr merged PR #4116.

Last updated: Oct 23 2024 at 20:03 UTC