Stream: git-wasmtime

Topic: wasmtime / PR #4113 bump spec interpreter commit to addre...

Wasmtime GitHub notifications bot (May 09 2022 at 15:33):

conrad-watt opened PR #4113 from main to main:

This commit of the interpreter introduces a new strategy for handling bitwise ops, which fixes the performance of popcnt, reinterpret, and signed integer comparison, and should result in fewer fuzzing timeouts (see https://github.com/bytecodealliance/wasmtime/issues/4059).

For reference, similar performance issues still exist for the integer operations clz, ctz, rem_s, rotl, rotr, wrap, extend_u, and extend_s - my current plan is to address these in a follow-up, so long as this current fix causes no issues.

Wasmtime GitHub notifications bot (May 09 2022 at 15:37):

conrad-watt edited PR #4113 from main to main:

This commit of the interpreter introduces a new strategy for handling bitwise ops, which fixes the performance of popcnt, reinterpret, and signed integer comparison, and should result in fewer fuzzing timeouts (see https://github.com/bytecodealliance/wasmtime/issues/4059).

For reference, similar performance issues still exist for the integer operations clz, ctz, rem_s, rotl, rotr, wrap, extend_u, and extend_s - my current plan is to address these in a follow-up, so long as this current fix causes no issues.

Wasmtime GitHub notifications bot (May 09 2022 at 15:38):

conrad-watt edited PR #4113 from main to main:

This commit of the interpreter introduces a new strategy for handling bitwise ops, which fixes the performance of popcnt, reinterpret, and signed integer comparison, and should result in fewer fuzzing timeouts (see https://github.com/bytecodealliance/wasmtime/issues/4059).

For reference, similar performance issues still exist for the integer operations clz, ctz, rem_s, rotl, rotr, wrap, extend_u, and extend_s - my current plan is to address these in a follow-up, so long as this current fix causes no issues.

EDIT: currently fuzzing locally with no issues found so far

Wasmtime GitHub notifications bot (May 09 2022 at 15:53):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (May 09 2022 at 16:09):

alexcrichton merged PR #4113.

Last updated: Dec 23 2024 at 12:05 UTC