Stream: git-wasmtime

Topic: wasmtime / PR #4101 Add ISA flag detection for s390x


view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:06):

uweigand opened PR #4101 from isaflag-wasmtime to main:

Adds support for s390x to check_compatible_with_isa_flag,
which fixes running the test suite on z15 and later.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:18):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:18):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:18):

alexcrichton created PR review comment:

Instead of a maze of #[cfg] statements here, while you're at it could this be updated to use cfg_if!?

Either that or say above let mut enabled = None or something like that. Basically I don't think it's worth it to have lots of negated cfg's to handle this variable.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:24):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:24):

akirilov-arm created PR review comment:

I think I tried the let mut enabled = None approach, which caused the compiler to complain about a value that was written, but not read, hence the current approach.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:30):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:30):

alexcrichton created PR review comment:

With a compiler warning I think it's fine to have a local #[allow] for something like this, that's easier to maintain than a complicated #[cfg] clause

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:52):

uweigand updated PR #4101 from isaflag-wasmtime to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:52):

uweigand submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 15:52):

uweigand created PR review comment:

OK, updated patch along those lines.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 16:13):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2022 at 16:26):

alexcrichton merged PR #4101.


Last updated: Dec 23 2024 at 12:05 UTC