Stream: git-wasmtime

Topic: wasmtime / PR #4096 bench-api: configure execution with a...

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2022 at 21:18):

abrown opened PR #4096 from parse-bench-api-flags to main:

As discussed in a previous Wasmtime meeting, we need a way to be able to configure Wasmtime when running it in the Sightglass benchmark infrastructure. The easiest way to do this seemed to pass a string from Sightglass to the bench-api library and parse this in the same way that Wasmtime parses its CLI flags. The structure that contains these flags is CommonOptions, so it has been moved to its own crate to be depended on by both wasmtime-cli and wasmtime-bench-api. Also, this change adds an externally-visible function for parsing a string into CommonOptions, which is used for configuring an engine.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2022 at 21:18):

abrown requested alexcrichton for a review on PR #4096.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2022 at 22:12):

abrown updated PR #4096 from parse-bench-api-flags to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2022 at 22:25):

abrown updated PR #4096 from parse-bench-api-flags to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2022 at 22:39):

abrown updated PR #4096 from parse-bench-api-flags to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2022 at 22:46):

abrown has marked PR #4096 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2022 at 23:02):

abrown updated PR #4096 from parse-bench-api-flags to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 14:20):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 14:20):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 14:20):

alexcrichton created PR review comment:

Could this be changed to listenfd since that's the root dep we want to not warn about?

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 19:56):

abrown updated PR #4096 from parse-bench-api-flags to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 19:59):

abrown updated PR #4096 from parse-bench-api-flags to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 23:04):

abrown updated PR #4096 from parse-bench-api-flags to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 23:30):

abrown merged PR #4096.

Last updated: Dec 23 2024 at 12:05 UTC