Stream: git-wasmtime

Topic: wasmtime / PR #4091 ISLE: remove all uses of argument pol...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2022 at 21:41):

cfallin opened PR #4091 from isle-remove-arg-polarity to main:

This PR removes "argument polarity": the feature of ISLE extractors that lets them take
inputs aside from the value to be matched.

Cases that need this expressivity have been subsumed by #4072 with if-let clauses;
we can now finally remove this misfeature of the language, which has caused significant
confusion and has always felt like a bit of a hack.

This PR comes in three commits: (i) first, it removes the feature from the ISLE compiler;
(ii) then, it removes it from the reference documentation; (iii) finally, it refactors away all
uses of the feature in our three existing backends written in ISLE.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2022 at 21:41):

cfallin requested abrown for a review on PR #4091.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2022 at 21:41):

cfallin requested fitzgen for a review on PR #4091.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2022 at 16:20):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2022 at 16:49):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2022 at 16:52):

cfallin merged PR #4091.

Last updated: Dec 23 2024 at 12:05 UTC