Stream: git-wasmtime

Topic: wasmtime / PR #4090 Add a flag to not expand interal extr...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2022 at 20:42):

avanhatt opened PR #4090 from isle-inlining-flag to main:

This is a WIP PR for ISLE to add a flag to optionally _not_ expand inline constructors.

The full details are in #4089, but the main idea is that we'd like to keep the actual term around (rather than expanding it like a macro) so that we can have annotations on the term. Rather than expanding, we treat the term like an external extractor. This change adds a flag to the TermEnv and exposes a new public function (alongside compile) called envs_for_analysis that sets the flag to false. Draft for now to get feedback on approach and improve the unit testing.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2022 at 20:49):

avanhatt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2022 at 20:49):

avanhatt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2022 at 20:49):

avanhatt created PR review comment:

@cfallin: do you think implementing this function (extractor_sig) makes sense in terms of returning an ExternalSig for an internal extractor? Would it be better to either refactor to separate this function, or rename the return type if we use it for both external and internal?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2022 at 20:49):

avanhatt created PR review comment:

Also hoping for feedback here: is there a better way to test that the extractor has not been expanded, other than searching for a specific term name?

Last updated: Dec 23 2024 at 12:05 UTC