Stream: git-wasmtime

Topic: wasmtime / PR #4082 Update to clap 3.*

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 16:15):

alexcrichton opened PR #4082 from update-clap to main:

This commit migrates all CLI commands internally used in this project
from structopt/clap2 to clap 3. The intent here is to ensure that we're
using maintained versions of the dependencies as structopt and clap 2
are less maintained nowadays. Most transitions were pretty
straightforward and mostly dealing with structopt/clap3 differences.

Along the way this also improves cargo deny a bit to ignore old crates we're using with outdated dependencies.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 16:48):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 16:50):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 16:50):

abrown created PR review comment:

@alexcrichton, are you sure this is correct? I still see activity in the repository and no slowdown in the number of downloads. It could be that it is just a stable project?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 16:51):

abrown edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 17:28):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 17:28):

alexcrichton created PR review comment:

I mostly say this in that the "upgrade env_logger" PR has been open for almost a year at this point

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 17:47):

alexcrichton merged PR #4082.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 18:25):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 18:25):

abrown created PR review comment:

Yeah, I saw that... But they're also still iterating on it (slowly). My comment was meant not to change this PR but as a "should I be using that crate?" question. I probably still will unless you think there's a better option out there.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 18:33):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2022 at 18:33):

alexcrichton created PR review comment:

Oh I think it's fine to keep using, although personally I use env_logger where necessary (but choice-of-logger is a pretty personal thing at this point still I think, I don't think there's an obvious answer)

Last updated: Dec 23 2024 at 12:05 UTC