Wasmtime GitHub notifications bot (Apr 28 2022 at 01:22): Wasmtime GitHub notifications bot (Apr 28 2022 at 01:22):cfallin requested fitzgen for a review on PR #4079.
Wasmtime GitHub notifications bot (Apr 28 2022 at 01:22):cfallin requested abrown for a review on PR #4079.
Wasmtime GitHub notifications bot (Apr 28 2022 at 01:22):cfallin opened PR #4079 from isle-collect-externs-early to main:
This fixes a bug where the ISLE compiler would refuse to accept
out-of-order declarations in the order of: (i) use of an implicit
conversion backed by an extern constructor; (ii) extern declaration
for that constructor.The issue was one of phase separation: we were capturing and noting
"extern constructor" status on terms in the same pass in which we were
typechecking and resolving implicit conversions. Given this knowledge,
the fix is straightforward: externs are picked up in a prior pass.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 28 2022 at 18:06):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Apr 28 2022 at 18:16):cfallin merged PR #4079.
Last updated: Nov 22 2024 at 17:03 UTC