Stream: git-wasmtime

Topic: wasmtime / PR #4046 Remove the `Paged` memory initializat...

Wasmtime GitHub notifications bot (Apr 18 2022 at 20:05):

alexcrichton opened PR #4046 from remove-paged-memory to main:

This commit simplifies the MemoryInitialization enum by removing the
Paged variant. The Paged variant was originally added for uffd, but
that support has now been removed in #4040. This is no longer necessary
but is still used as an intermediate step of becoming a Static variant
of initialized memory (which copy-on-write uses). As a result this
commit largely modifies the static initialization of memory steps and
folds the two methods together.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 19 2022 at 14:31):

alexcrichton requested peterhuene for a review on PR #4046.

Wasmtime GitHub notifications bot (May 05 2022 at 05:50):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (May 05 2022 at 05:50):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (May 05 2022 at 05:50):

peterhuene created PR review comment:

        // Validate that the memory information collected is indeed valid for

Wasmtime GitHub notifications bot (May 05 2022 at 05:50):

peterhuene created PR review comment:

        // This method only attempts to transform a `Segmented` memory init

Wasmtime GitHub notifications bot (May 05 2022 at 14:44):

alexcrichton updated PR #4046 from remove-paged-memory to main.

Wasmtime GitHub notifications bot (May 05 2022 at 14:44):

alexcrichton merged PR #4046.

Last updated: Nov 22 2024 at 16:03 UTC