Stream: git-wasmtime

Topic: wasmtime / PR #4021 [AArch64] Port atomic rmw to ISLE

Wasmtime GitHub notifications bot (Apr 13 2022 at 14:30):

sparker-arm opened PR #4021 from isle-atomic-rmw to main:

Also fix the current implementation, as AArch64
AtomicRMWOp::Clr != AtomicRmwOp::And, as the input needs to be
inverted first. We now also lower Xchg to Swp and Sub to Add
with a negated input.

Copyright (c) 2022, Arm Limited.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 13 2022 at 14:55):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 14 2022 at 13:40):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 14 2022 at 20:42):

cfallin updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 14 2022 at 22:46):

cfallin updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 20 2022 at 11:49):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 20 2022 at 16:26):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 20 2022 at 16:26):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 20 2022 at 16:26):

cfallin created PR review comment:

The writable_reg_to_reg is unnecessary now with implicit conversions (harmless, just more verbose than needed).

Wasmtime GitHub notifications bot (Apr 21 2022 at 08:35):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 21 2022 at 11:24):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 21 2022 at 12:26):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 22 2022 at 08:12):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 27 2022 at 09:54):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 27 2022 at 10:35):

sparker-arm updated PR #4021 from isle-atomic-rmw to main.

Wasmtime GitHub notifications bot (Apr 27 2022 at 19:46):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Apr 27 2022 at 19:46):

akirilov-arm created PR review comment:

@cfallin I depend on this PR in #4034, so both @sparker-arm and I would appreciate any feedback on the ISLE code - it should look good now.

Wasmtime GitHub notifications bot (Apr 27 2022 at 20:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 27 2022 at 20:14):

cfallin merged PR #4021.

Last updated: Nov 22 2024 at 16:03 UTC