Stream: git-wasmtime

Topic: wasmtime / PR #4017 x64: fix miscompilation of `select.i128`


view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2022 at 23:00):

abrown opened PR #4017 from issue-3963 to main:

Issue #3963 identified a miscompilation with select in which the second
in the pair of CMOVs (one pair per i128 register) used the wrong
flag. This change fixes the error in the x64 ISLE helper function
emitting these CMOV instructions.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2022 at 23:00):

abrown requested cfallin for a review on PR #4017.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2022 at 23:04):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2022 at 23:05):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2022 at 23:21):

abrown updated PR #4017 from issue-3963 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2022 at 16:56):

abrown merged PR #4017.


Last updated: Dec 23 2024 at 13:07 UTC