Wasmtime GitHub notifications bot (Apr 11 2022 at 20:23): Wasmtime GitHub notifications bot (Apr 11 2022 at 20:23):fitzgen requested alexcrichton for a review on PR #4016.
Wasmtime GitHub notifications bot (Apr 11 2022 at 20:23):fitzgen opened PR #4016 from refactor-table-ops-fuzz-target to main:
This makes the generator more similar to
wasm-smithwhere it is keeping track
of what is on the stack and making choices about what instructions are valid to
generate given the current stack state. This should in theory allow the
generator to emit GC calls while there are live refs on the stack.Fixes #3917
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 11 2022 at 20:48):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 11 2022 at 20:48):alexcrichton created PR review comment:
stray log? (seems fine to stay may just want to tweak the string)
Wasmtime GitHub notifications bot (Apr 11 2022 at 20:48):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 11 2022 at 20:53):fitzgen updated PR #4016 from refactor-table-ops-fuzz-target to main.
Wasmtime GitHub notifications bot (Apr 11 2022 at 21:33):fitzgen merged PR #4016.
Last updated: Dec 23 2024 at 12:05 UTC