Wasmtime GitHub notifications bot (Apr 05 2022 at 08:03): Wasmtime GitHub notifications bot (Apr 05 2022 at 08:03):haraldh opened PR #3995 from preopen_socket_compat to main:
Existing libraries and applications use
fd_prestat_get()to find out
about preopened directories. To not break the old logic of those,
if preopened sockets are added, push the directories first.See https://github.com/bytecodealliance/wasmtime/issues/3936
Signed-off-by: Harald Hoyer <harald@profian.com>
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 05 2022 at 08:04):haraldh edited PR #3995 from preopen_socket_compat to main:
Existing libraries and applications use
fd_prestat_get()to find out
about preopened directories. To not break the old logic of those,
if preopened sockets are added, push the directories first.Fixes: https://github.com/bytecodealliance/wasmtime/issues/3936
Signed-off-by: Harald Hoyer <harald@profian.com>
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Last updated: Oct 23 2024 at 20:03 UTC