Stream: git-wasmtime

Topic: wasmtime / PR #3987 Split wasmtime-runtime's single gette...

Wasmtime GitHub notifications bot (Mar 31 2022 at 20:11):

alexcrichton opened PR #3987 from refactor-item-getters to main:

This splits the existing lookup_by_declaration function into a
lookup-per-type-of-item. This refactor ends up cleaning up a fair bit of
code in the wasmtime crate by removing a number of unreachable!()
blocks which are now no longer necessary.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 31 2022 at 20:25):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Mar 31 2022 at 21:24):

alexcrichton merged PR #3987.

Last updated: Oct 23 2024 at 20:03 UTC