Stream: git-wasmtime

Topic: wasmtime / PR #3976 cranelift: remove `load_complex` and ...

Wasmtime GitHub notifications bot (Mar 30 2022 at 23:26):

abrown opened PR #3976 from remove-complex to main:

This change removes all variants of load*_complex and store*_complex
from Cranelift; this is a breaking change to the instructions exposed by
CLIF. The complete list of instructions removed is: load_complex,
store_complex, uload8_complex, sload8_complex, istore8_complex,
sload8_complex, uload16_complex, sload16_complex,
istore16_complex, uload32_complex, sload32_complex,
istore32_complex, uload8x8_complex, sload8x8_complex,
sload16x4_complex, uload16x4_complex, uload32x2_complex,
sload32x2_complex.

The rationale for this removal is that the Cranelift backend now has the
ability to pattern-match multiple upstream additions in order to
calculate the address to access. Previously, this was not possible so
the *_complex instructions were needed. Over time, these instructions
have fallen out of use in this repository, making the additional
overhead of maintaining them a chore.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 31 2022 at 00:04):

abrown has marked PR #3976 as ready for review.

Wasmtime GitHub notifications bot (Mar 31 2022 at 04:43):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 31 2022 at 04:43):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 31 2022 at 04:44):

cfallin created PR review comment:

we can just remove this parenthetical in the comment, I think.

Wasmtime GitHub notifications bot (Mar 31 2022 at 16:00):

abrown updated PR #3976 from remove-complex to main.

Wasmtime GitHub notifications bot (Mar 31 2022 at 17:05):

abrown merged PR #3976.

Last updated: Dec 23 2024 at 12:05 UTC