Stream: git-wasmtime

Topic: wasmtime / PR #3975 Use tokio::test instead of `dummy_wak...

Wasmtime GitHub notifications bot (Mar 30 2022 at 21:14):

alexcrichton opened PR #3975 from more-tokio to main:

Currently wasmtime's async tests use a mixture of #[tokio::test] and
dummy_waker. To be consistent this tries to move all tests possible to
#[tokio::test] and just a two need to keep using dummy_waker (no
renamed to noop_waker) due to what they're testing.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 05 2022 at 16:02):

alexcrichton updated PR #3975 from more-tokio to main.

Wasmtime GitHub notifications bot (Apr 05 2022 at 16:03):

alexcrichton requested peterhuene for a review on PR #3975.

Wasmtime GitHub notifications bot (Apr 18 2022 at 20:12):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2022 at 20:56):

peterhuene merged PR #3975.

Last updated: Dec 23 2024 at 12:05 UTC