Stream: git-wasmtime

Topic: wasmtime / PR #3973 x64: port the remainder of `select` t...

Wasmtime GitHub notifications bot (Mar 30 2022 at 19:36):

abrown opened PR #3973 from isle-select-icmp to main:

Previous changes had ported the difficult "select based on an fcmp"
patterns to ISLE; this completes porting of select by moving over the
final two kinds of patterns:

• select based on an icmp
• select based on a value

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 30 2022 at 19:36):

abrown requested cfallin for a review on PR #3973.

Wasmtime GitHub notifications bot (Mar 30 2022 at 19:37):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Mar 30 2022 at 19:37):

abrown created PR review comment:

This may be another instance of https://github.com/bytecodealliance/wasmtime/issues/3744.

Wasmtime GitHub notifications bot (Mar 30 2022 at 20:18):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 30 2022 at 20:32):

abrown merged PR #3973.

Last updated: Dec 23 2024 at 12:05 UTC