Wasmtime GitHub notifications bot (Mar 28 2022 at 15:31): Wasmtime GitHub notifications bot (Mar 28 2022 at 15:31):alexcrichton opened PR #3964 from more-module-knobs to main:
This commit adds a method,
Module::initialize_copy_on_write_image,
which will explicitly create the copy-on-write image during the method
call instead of lazily deferring it until the first instantiation of a
module. Given the relative expense of creation of a memfd on Linux this
can otherwise run the risk of unnaturally perturbing the
time-of-instantiation of a module. Additionally whenever lazy
initialization is provided in an API it's typically good practice to
also have an optionally-called forced initialization.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 28 2022 at 16:35):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Apr 11 2022 at 17:51):alexcrichton merged PR #3964.
Last updated: Dec 23 2024 at 12:05 UTC