Stream: git-wasmtime

Topic: wasmtime / PR #3958 Remove the module linking implementat...

Wasmtime GitHub notifications bot (Mar 23 2022 at 18:19):

alexcrichton opened PR #3958 from remove-module-linking to main:

This commit removes the experimental implementation of the module
linking WebAssembly proposal from Wasmtime. The module linking is no
longer intended for core WebAssembly but is instead incorporated into
the component model now at this point. This means that very large parts
of Wasmtime's implementation of module linking are no longer applicable
and would change greatly with an implementation of the component model.

The main purpose of this is to remove Wasmtime's reliance on the support
for module-linking in wasmparser and tooling crates. With this
reliance removed we can move over to the component-model branch of
wasmparser and use the updated support for the component model.
Additionally given the trajectory of the component model proposal the
embedding API of Wasmtime will not look like what it looks like today
for WebAssembly. For example the core wasm Instance will not change
and instead a Component is likely to be added instead.

Some more rationale for this is in #3941, but the basic idea is that I
feel that it's not going to be viable to develop support for the
component model on a non-main branch of Wasmtime. Additionaly I don't
think it's viable, for the same reasons as wasm-tools, to support the
old module linking proposal and the new component model at the same
time.

This commit takes a moment to not only delete the existing module
linking implementation but some abstractions are also simplified. For
example module serialization is a bit simpler that there's only one
module. Additionally instantiation is much simpler since the only
initializer we have to deal with are imports and nothing else.

Closes #3941

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 23 2022 at 18:53):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Mar 23 2022 at 18:53):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Mar 23 2022 at 18:53):

peterhuene created PR review comment:

Wasmtime GitHub notifications bot (Mar 23 2022 at 19:11):

alexcrichton updated PR #3958 from remove-module-linking to main.

Wasmtime GitHub notifications bot (Mar 23 2022 at 19:15):

alexcrichton updated PR #3958 from remove-module-linking to main.

Wasmtime GitHub notifications bot (Mar 23 2022 at 19:57):

alexcrichton merged PR #3958.

Last updated: Dec 23 2024 at 12:05 UTC