Stream: git-wasmtime

Topic: wasmtime / PR #3956 Fix for issue #3948

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2022 at 19:56):

brianjjones opened PR #3956 from fix_layout to main:

Also updating the CI script to use the latest
version of OpenVINO.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2022 at 23:54):

abrown requested abrown for a review on PR #3956.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2022 at 23:55):

brianjjones updated PR #3956 from fix_layout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2022 at 00:11):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2022 at 00:11):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2022 at 00:11):

abrown created PR review comment:

Instead of hard-coding this here, can we do this down in set_input by the TODO item at line 78 (with the appropriate input ID from the index argument)? There is a need to figure out how to allow different kinds of image layouts but for now keeping it at NHWC should be fine, especially if we keep it close to the TODO below.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2022 at 02:00):

brianjjones submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2022 at 02:00):

brianjjones created PR review comment:

This would require changing Arc<openvino::CNNNetwork> to Arc<Mutex<openvino::CNNNetwork>> in order to get a mutable copy of the CNNNetwork, which is needed for set_input_layout. Even doing this I'm currently still getting the parameter mismatch error moving it here. I'll try a few more things and see about removing the hard coded value.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 24 2022 at 00:43):

brianjjones updated PR #3956 from fix_layout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 24 2022 at 17:04):

brianjjones updated PR #3956 from fix_layout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 24 2022 at 17:08):

brianjjones updated PR #3956 from fix_layout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 24 2022 at 17:14):

brianjjones updated PR #3956 from fix_layout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 24 2022 at 17:15):

brianjjones requested abrown for a review on PR #3956.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 24 2022 at 18:57):

abrown updated PR #3956 from fix_layout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 24 2022 at 20:32):

abrown merged PR #3956.

Last updated: Oct 23 2024 at 20:03 UTC