Stream: git-wasmtime

Topic: wasmtime / PR #3950 [AArch64] Refactor ALUOp3

Wasmtime GitHub notifications bot (Mar 21 2022 at 11:04):

sparker-arm opened PR #3950 from aarch64-merge-aluop3 to main:

As well as adding generic pattern for msub along with runtests
for madd and msub.

Copyright (c) 2022, Arm Limited.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 28 2022 at 16:36):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 28 2022 at 16:36):

cfallin created PR review comment:

Similarly here, put_in_reg is an implicit conversion from Value to Reg, and value_reg is an implicit conversion from Reg to ValueRegs, so this can be just (msub ty y z x).

Wasmtime GitHub notifications bot (Mar 28 2022 at 16:36):

cfallin created PR review comment:

The def_inst here is now optional, given the implicit conversions we recently added; so this pattern can be written as (isub x (imul y z)), which is a bit easier to read!

Wasmtime GitHub notifications bot (Mar 28 2022 at 16:36):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 13 2022 at 11:01):

sparker-arm updated PR #3950 from aarch64-merge-aluop3 to main.

Wasmtime GitHub notifications bot (Apr 14 2022 at 02:29):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 14 2022 at 18:20):

cfallin updated PR #3950 from aarch64-merge-aluop3 to main.

Wasmtime GitHub notifications bot (Apr 14 2022 at 19:16):

cfallin merged PR #3950.

Last updated: Dec 23 2024 at 12:05 UTC