Stream: git-wasmtime

Topic: wasmtime / PR #3947 x64: prefix all machine instructions ...

Wasmtime GitHub notifications bot (Mar 18 2022 at 23:39):

abrown opened PR #3947 from isle-prefix to main:

This change is refactoring only--it should have no logic changes. As
discussed previously, prefixing all machine code instructions with
x64_ will make it easier to identify what parts of the ISLE code
correspond to single instructions and what parts rely on helpers that
may emit more than one instruction.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 18 2022 at 23:41):

abrown updated PR #3947 from isle-prefix to main.

Wasmtime GitHub notifications bot (Mar 18 2022 at 23:43):

abrown requested cfallin for a review on PR #3947.

Wasmtime GitHub notifications bot (Mar 18 2022 at 23:43):

abrown requested fitzgen for a review on PR #3947.

Wasmtime GitHub notifications bot (Mar 18 2022 at 23:47):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 19 2022 at 00:53):

abrown merged PR #3947.

Last updated: Nov 22 2024 at 17:03 UTC