Stream: git-wasmtime

Topic: wasmtime / PR #3946 x64: improve generation of i128 `icmp`

Wasmtime GitHub notifications bot (Mar 18 2022 at 18:52):

abrown opened PR #3946 from isle-i128-icmp-improvement to main:

Previously, we used the flags of AND for SETcc. This change uses
TEST instead, which discards the AND result but sets the flags needed
for SETcc. This reduces register pressure slightly for this sequence.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 18 2022 at 18:52):

abrown requested cfallin for a review on PR #3946.

Wasmtime GitHub notifications bot (Mar 18 2022 at 18:54):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 18 2022 at 21:19):

abrown updated PR #3946 from isle-i128-icmp-improvement to main.

Wasmtime GitHub notifications bot (Mar 18 2022 at 23:36):

abrown merged PR #3946.

Last updated: Dec 23 2024 at 13:07 UTC