Stream: git-wasmtime

Topic: wasmtime / PR #3915 fix(wasi): enable all `WasiFile`s to ...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 18:42):

npmccallum opened PR #3915 from wasi to release-0.35.1:

Currently, the use of the downcast method means that you have to use one
of the hard-coded types. But Enarx needs to define its own WasiFile
implementations. This works fine, except the resulting files cannot be
used in poll because they aren't part of the hard-coded list.

Replace this with an accessor method for the pollable type in
WasiFile. Because we provide a default implementation of the method
and manually implement it on all the hard-coded types, this is backwards
compatible.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 19:01):

pchickey requested alexcrichton for a review on PR #3915.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2022 at 19:16):

npmccallum closed without merge PR #3915.


Last updated: Nov 22 2024 at 16:03 UTC