Stream: git-wasmtime

Topic: wasmtime / PR #3914 Eagerly create `ModuleMemoryImages`

Wasmtime GitHub notifications bot (Mar 10 2022 at 17:27):

alexcrichton opened PR #3914 from less-lazy to main:

This commit removes the currently existing laziness-via-OnceCell when
a Module is created for creating a ModuleMemoryImages data
structure. Processing of data is now already shifted to compile time for
the wasm module which means that creating a ModuleMemoryImages is
either cheap because the module is backed by a file on disk, it's a
single write into the kernel to a memfd, or it's cheap as it's not
supported. This should help make module instantiation time more
deterministic, even for the first instantiation of a module.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 10 2022 at 17:37):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 10 2022 at 18:23):

alexcrichton merged PR #3914.

Last updated: Nov 22 2024 at 16:03 UTC