Stream: git-wasmtime

Topic: wasmtime / PR #3913 fix(wasi): enable all `WasiFile`s to ...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 13:54):

npmccallum opened PR #3913 from wasi to main:

Currently, the use of the downcast method means that you have to use one
of the hard-coded types. But Enarx needs to define its own WasiFile
implementations. This works fine, except the resulting files cannot be
used in poll because they aren't part of the hard-coded list.

Replace this with an accessor method for the pollable type in
WasiFile. Because we provide a default implementation of the method
and manually implement it on all the hard-coded types, this is backwards
compatible.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 13:56):

npmccallum updated PR #3913 from wasi to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 14:21):

npmccallum updated PR #3913 from wasi to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 15:04):

npmccallum updated PR #3913 from wasi to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 15:29):

npmccallum updated PR #3913 from wasi to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 16:09):

npmccallum updated PR #3913 from wasi to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 18:08):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2022 at 18:09):

pchickey merged PR #3913.


Last updated: Dec 23 2024 at 12:05 UTC