Wasmtime GitHub notifications bot (Mar 09 2022 at 19:49): Wasmtime GitHub notifications bot (Mar 09 2022 at 19:49):alexcrichton opened PR #3908 from fix-align-arm64 to main:
Previously (as in an hour ago) #3905 landed a new ability for fuzzing to
arbitrarily insert padding between functions. Running some fuzzers
locally though this instantly hit a lot of problems on AArch64 because
the arbitrary padding isn't aligned to 4 bytes like all other functions
are. To fix this issue appending functions now correctly aligns the
output as appropriate for the platform. The alignment argument for
appending was switched toNonewhereNonemeans "use the platform
default" and otherwise and explicit alignment can be specified for
inserting other data (like arbitrary padding or Windows unwind tables).<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 09 2022 at 20:07):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Mar 09 2022 at 21:45):alexcrichton merged PR #3908.
Last updated: Dec 23 2024 at 12:05 UTC