rvolosatovs opened PR #3895 from feature/generic-wasi-ctx
to main
:
In some use cases it is desirable to provide a custom snapshot WASI
context. Facilitate this by depending on a combination of traits
required rather than concrete type in the signature.
pchickey submitted PR review.
rvolosatovs edited PR #3895 from feature/generic-wasi-ctx
to main
:
In some use cases it is desirable to provide a custom snapshot WASI
context. Facilitate this by depending on a combination of traits
required rather than concrete type in the signature.This change allows for e.g. wrapping
WasiCtx
into a struct and providing custom implementations for traits
rvolosatovs updated PR #3895 from feature/generic-wasi-ctx
to main
.
rvolosatovs created PR review comment:
Not the prettiest fix, but I didn't manage to find a simple way to modify the macro to emit
,
ifbounds
are provided. Are there any suggestions?
rvolosatovs submitted PR review.
pchickey submitted PR review.
pchickey created PR review comment:
iirc this is a common macro-rules problem. Not a big deal, we only use the macro in this file.
pchickey submitted PR review.
rvolosatovs updated PR #3895 from feature/generic-wasi-ctx
to main
.
rvolosatovs submitted PR review.
rvolosatovs created PR review comment:
Found a better way by simply reordering them
rvolosatovs updated PR #3895 from feature/generic-wasi-ctx
to main
.
alexcrichton merged PR #3895.
Last updated: Dec 23 2024 at 12:05 UTC