Stream: git-wasmtime

Topic: wasmtime / PR #3886 x64: port `icmp` to ISLE

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2022 at 00:16):

abrown opened PR #3886 from isle-icmp to main:

This change ports the lowering of the icmp instruction to ISLE.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2022 at 18:20):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2022 at 18:20):

fitzgen created PR review comment:

We've been naming conversions in ISLE like foo_to_bar since they aren't namespaced methods (so if we wanted to construct something else from IntCC the function name as written would be ambiguous).

So this should be intcc_to_cc.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 17:36):

abrown updated PR #3886 from isle-icmp to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 17:40):

abrown updated PR #3886 from isle-icmp to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 17:40):

abrown has marked PR #3886 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 17:50):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 17:50):

abrown created PR review comment:

If we end up merging this as-is, I'll add an issue to remind us to make sure these extra moves go away in the new regalloc.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 18:04):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 18:04):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 18:04):

cfallin created PR review comment:

We have support for emitting test I think, which IIRC is to and what cmp is to sub (i.e. doesn't write a dest, so wouldn't need to add to register pressure here) -- would it be possible to use that here?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 18:17):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 18:17):

abrown created PR review comment:

Ah, yeah, that's a good point; let me do that in a follow-on PR.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2022 at 18:22):

abrown merged PR #3886.

Last updated: Dec 06 2025 at 06:05 UTC