abrown opened PR #3886 from isle-icmp
to main
:
This change ports the lowering of the
icmp
instruction to ISLE.
fitzgen submitted PR review.
fitzgen created PR review comment:
We've been naming conversions in ISLE like
foo_to_bar
since they aren't namespaced methods (so if we wanted to construct something else fromIntCC
the function name as written would be ambiguous).So this should be
intcc_to_cc
.
abrown updated PR #3886 from isle-icmp
to main
.
abrown updated PR #3886 from isle-icmp
to main
.
abrown has marked PR #3886 as ready for review.
abrown submitted PR review.
abrown created PR review comment:
If we end up merging this as-is, I'll add an issue to remind us to make sure these extra moves go away in the new regalloc.
cfallin submitted PR review.
cfallin submitted PR review.
cfallin created PR review comment:
We have support for emitting
test
I think, which IIRC is toand
whatcmp
is tosub
(i.e. doesn't write a dest, so wouldn't need to add to register pressure here) -- would it be possible to use that here?
abrown submitted PR review.
abrown created PR review comment:
Ah, yeah, that's a good point; let me do that in a follow-on PR.
abrown merged PR #3886.
Last updated: Dec 23 2024 at 13:07 UTC