Wasmtime GitHub notifications bot (Feb 28 2022 at 15:59): Wasmtime GitHub notifications bot (Feb 28 2022 at 15:59):alexcrichton opened PR #3861 from smaller-wasm-stack to main:
This commit aims to achieve the goal of being able to run the test suite
on Windows with--test-threads 1, or more notably allowing Wasmtime's
defaults to work better with the main thread on Windows which appears to
have a smaller stack by default than Linux by comparison. In decreasing
the default wasm stack size a test is also update to probe for less
stack to work on Windows' main thread by default, ideally allowing the
full test suite to work with--test-threads 1(although this isn't
added to CI as it's not really critical).Closes #3857
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 28 2022 at 17:15):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 28 2022 at 18:18):alexcrichton merged PR #3861.
Last updated: Nov 22 2024 at 17:03 UTC