Stream: git-wasmtime

Topic: wasmtime / PR #3860 Limit stack frame captures to at most...

Wasmtime GitHub notifications bot (Feb 28 2022 at 15:17):

alexcrichton opened PR #3860 from limit-stack to main:

This places a static limit on the number of frames captured by Wasmtime
to ensure that stack traces, for whatever reason, don't get egregiously
long like the issues we've seen in recently in the windows-2022 CI
upgrade where stack overflow tests caused the system unwinder to report
an infinite stream of frames.

Closes #3858

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 28 2022 at 18:52):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Feb 28 2022 at 18:52):

bjorn3 created PR review comment:

Could you make this configurable? There are cases where long backtraces are not a bug. For example rustc recurses a lot in some places.

Wasmtime GitHub notifications bot (Mar 21 2022 at 21:00):

alexcrichton closed without merge PR #3860.

Wasmtime GitHub notifications bot (Mar 22 2022 at 14:16):

alexcrichton reopened PR #3860 from limit-stack to main.

Wasmtime GitHub notifications bot (Mar 22 2022 at 14:16):

alexcrichton closed without merge PR #3860.

Last updated: Nov 22 2024 at 16:03 UTC