Wasmtime GitHub notifications bot (Feb 26 2022 at 01:26): Wasmtime GitHub notifications bot (Feb 26 2022 at 01:26):cfallin opened PR #3855 from isle-misc-ops to main:
Depends on / stacked on top of #3848, #3849.
Wasmtime GitHub notifications bot (Feb 26 2022 at 01:26):cfallin requested abrown for a review on PR #3855.
Wasmtime GitHub notifications bot (Feb 28 2022 at 17:50):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Feb 28 2022 at 17:50):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Feb 28 2022 at 17:50):fitzgen created PR review comment:
Existing/curious: Do you know why
debugtrapisn't a safe point? Our other traps are safe points.
Wasmtime GitHub notifications bot (Feb 28 2022 at 19:16):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 28 2022 at 19:16):cfallin created PR review comment:
I'm actually not sure! For what it's worth,
hltis a bit of an odd choice here as well (it can only execute in kernel mode, and I think generatesSIGILLin userspace). I guess the idea is that it's not meant to be a "normal" transfer of control to the runtime paired with the generated code, but rather a place where a debugger could catch a signal or hook in withptraceor something of the sort, so setting up state for a "normal" runtime invocation to e.g. scan the stack wouldn't be useful. I'm not sure though.In the absence of more context here I'm inclined to leave the lowering as-is (translated from existing), but we should definitely ask whether this opcode is even necessary, or at least what its precise guarantees should be, when we get to cleaning up the CLIF opcode space...
Wasmtime GitHub notifications bot (Feb 28 2022 at 20:56):cfallin updated PR #3855 from isle-misc-ops to main.
Wasmtime GitHub notifications bot (Feb 28 2022 at 21:28):cfallin merged PR #3855.
Last updated: Nov 22 2024 at 16:03 UTC