Wasmtime GitHub notifications bot (Feb 25 2022 at 05:21): Wasmtime GitHub notifications bot (Feb 25 2022 at 05:21):cfallin opened PR #3849 from isle-extends to main:
Builds on #3848; second commit is new.
Wasmtime GitHub notifications bot (Feb 25 2022 at 05:21):cfallin requested fitzgen for a review on PR #3849.
Wasmtime GitHub notifications bot (Feb 25 2022 at 05:21):cfallin requested abrown for a review on PR #3849.
Wasmtime GitHub notifications bot (Feb 25 2022 at 17:01):abrown submitted PR review.
Wasmtime GitHub notifications bot (Feb 25 2022 at 17:01):abrown submitted PR review.
Wasmtime GitHub notifications bot (Feb 25 2022 at 17:01):abrown created PR review comment:
I wish there was an auto-formatter for Lisp we could wire up to the rebuild task to get consistent, canonical formatting for all this code.
Wasmtime GitHub notifications bot (Feb 25 2022 at 19:53):cfallin updated PR #3849 from isle-extends to main.
Wasmtime GitHub notifications bot (Feb 25 2022 at 19:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 25 2022 at 19:55):cfallin created PR review comment:
Ah, I use Emacs' built-in indenting with
lisp-mode, which seems to work OK, though I agree it'd be nice to have the equivalent tocargo fmt.(Emacs does run in batch mode from the commandline... though it's probably a bit much to ask everyone to install Emacs just for code formatting :-) )
Wasmtime GitHub notifications bot (Feb 25 2022 at 23:54):cfallin updated PR #3849 from isle-extends to main.
Wasmtime GitHub notifications bot (Feb 28 2022 at 19:11):cfallin updated PR #3849 from isle-extends to main.
Wasmtime GitHub notifications bot (Feb 28 2022 at 19:49):cfallin merged PR #3849.
Last updated: Nov 22 2024 at 16:03 UTC