Stream: git-wasmtime

Topic: wasmtime / PR #3849 ISLE: port extend/reduce opcodes on ...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 05:21):

cfallin opened PR #3849 from isle-extends to main:

Builds on #3848; second commit is new.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 05:21):

cfallin requested fitzgen for a review on PR #3849.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 05:21):

cfallin requested abrown for a review on PR #3849.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 17:01):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 17:01):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 17:01):

abrown created PR review comment:

I wish there was an auto-formatter for Lisp we could wire up to the rebuild task to get consistent, canonical formatting for all this code.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 19:53):

cfallin updated PR #3849 from isle-extends to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 19:55):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 19:55):

cfallin created PR review comment:

Ah, I use Emacs' built-in indenting with lisp-mode, which seems to work OK, though I agree it'd be nice to have the equivalent to cargo fmt.

(Emacs does run in batch mode from the commandline... though it's probably a bit much to ask everyone to install Emacs just for code formatting :-) )

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2022 at 23:54):

cfallin updated PR #3849 from isle-extends to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2022 at 19:11):

cfallin updated PR #3849 from isle-extends to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2022 at 19:49):

cfallin merged PR #3849.


Last updated: Dec 23 2024 at 12:05 UTC