Wasmtime GitHub notifications bot (Feb 23 2022 at 21:53): Wasmtime GitHub notifications bot (Feb 23 2022 at 21:53):alexcrichton opened PR #3846 from maybe-multi-memory-bug to main:
This commit fixes a potential issue where the fast-path instantiate in
MemoryImageSlotwhere when the previous image is compared against the
new image it only performed file descriptor equality, but nowadays with
loading images from*.cwasmfiles there might be multiple images in
the same file so the offsets also need to be considered. I think this
isn't really easy to hit today, it would require combining both module
linking and multi-memory which gets into the realm of being pretty
esoteric so I haven't added a test case here for this.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 23 2022 at 21:53):alexcrichton requested cfallin for a review on PR #3846.
Wasmtime GitHub notifications bot (Feb 23 2022 at 22:34):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 23 2022 at 22:41):alexcrichton merged PR #3846.
Last updated: Dec 23 2024 at 12:05 UTC