cfallin opened PR #3845 from isle-fuzzing-fix
to main
:
It seems our
compile
fuzz target for ISLE has not been regularly
tested, as it was never updated for theisle
->cranelift_isle
crate
renaming. This PR fixes it to compile again.This also includes a simple fix in the typechecking: when verifying that
a term decl is valid, we might insert a term ID into the name->ID map
before fully checking that all of the types exist, and then skipping
(for error recovery purposes) the actual push onto the term-signature
vector if one of the types does have an error. This phantom TID can
later cause a panic. The fix is to avoid adding to the map until we have
fully verified the term decl.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
cfallin requested fitzgen for a review on PR #3845.
fitzgen submitted PR review.
cfallin updated PR #3845 from isle-fuzzing-fix
to main
.
cfallin merged PR #3845.
Last updated: Dec 23 2024 at 12:05 UTC