Stream: git-wasmtime

Topic: wasmtime / PR #3833 Enable SSE 4.2 unconditionally

Wasmtime GitHub notifications bot (Feb 22 2022 at 17:43):

alexcrichton opened PR #3833 from enable-sse-42 to main:

Fuzzing over the weekend found that i64x2 comparison operators
require pcmpgtq which is an SSE 4.2 instruction. Along the lines of #3816
this commit unconditionally enables and requires SSE 4.2 for compilation
and fuzzing. It will no longer be possible to create a compiler for
x86_64 with simd enabled if SSE 4.2 is disabled.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 22 2022 at 17:45):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 22 2022 at 17:47):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 22 2022 at 17:47):

cfallin created PR review comment:

Update comment here? s/4.1/4.2/

Wasmtime GitHub notifications bot (Feb 22 2022 at 17:48):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 22 2022 at 18:20):

alexcrichton updated PR #3833 from enable-sse-42 to main.

Wasmtime GitHub notifications bot (Feb 22 2022 at 19:23):

alexcrichton merged PR #3833.

Last updated: Nov 22 2024 at 16:03 UTC